-
Notifications
You must be signed in to change notification settings - Fork 974
EC2 IMDS Changes to Support Account ID #6176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EC2 IMDS Changes to Support Account ID #6176
Conversation
...rc/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java
Outdated
Show resolved
Hide resolved
...rc/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java
Outdated
Show resolved
Hide resolved
...software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProviderAccountIDTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java
Outdated
Show resolved
Hide resolved
...ftware/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProviderIntegrationTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java
Show resolved
Hide resolved
...rc/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java
Outdated
Show resolved
Hide resolved
core/regions/src/main/java/software/amazon/awssdk/regions/util/HttpResourcesUtils.java
Show resolved
Hide resolved
...rc/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java
Show resolved
Hide resolved
-created a new integration test file for IMDS extended url separating it from legacy -Included the status code to the fallback logic
- Removed the duplicate test files - Make ApiVersion Volatile
...rc/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java
Outdated
Show resolved
Hide resolved
...ftware/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProviderExtendedApiTest.java
Outdated
Show resolved
Hide resolved
...ftware/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProviderExtendedApiTest.java
Show resolved
Hide resolved
...th/src/main/java/software/amazon/awssdk/auth/credentials/internal/HttpCredentialsLoader.java
Outdated
Show resolved
Hide resolved
...rc/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java
Show resolved
Hide resolved
...rc/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java
Outdated
Show resolved
Hide resolved
...rc/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java
Outdated
Show resolved
Hide resolved
-Adding additional tests -Updating to use AtomicReference
...rc/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java
Outdated
Show resolved
Hide resolved
...rc/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java
Outdated
Show resolved
Hide resolved
...rc/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java
Outdated
Show resolved
Hide resolved
Updating the debug logging message Modified the fallback logic in refresh credentials
...rc/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java
Show resolved
Hide resolved
alextwoods
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
edfe8d5
into
feature/master/IMDS-AccountID-Support
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |



Add support for extracting account ID from Instance Metadata Credentials Provider
Motivation and Context
Add support in IMDS credentials provider to retrieve accountID.
Modifications
/latest/meta-data/iam/security-credentials-extended/IMDS endpointTesting
Added unit tests using WireMock to verify:
Performed integration testing on EC2:
Screenshots (if appropriate)
Tested Code:
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License