Skip to content

Add support for protocol test error cases + add cbor error cases#6207

Merged
alextwoods merged 3 commits intomasterfrom
alexwoo/protocol-test-error-cases
Jun 25, 2025
Merged

Add support for protocol test error cases + add cbor error cases#6207
alextwoods merged 3 commits intomasterfrom
alexwoo/protocol-test-error-cases

Conversation

@alextwoods
Copy link
Contributor

Add support for protocol test error cases + add cbor error cases.

Note: This backports (forward ports?) support from V1.

Motivation and Context

We currently don't support error cases (errorUnmarshall) in protocol tests.

Modifications

  • Add support for errorUnmarshall action + error class to be specified in test cases.
  • Add test runner support + error assertion implementation.
  • Add the Rpcv2cbor error protocol tests.

Testing

  • Added new test cases

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods requested a review from a team as a code owner June 24, 2025 22:28
@alextwoods alextwoods added the changelog-not-required Indicate changelog entry is not required for a specific PR label Jun 24, 2025
@alextwoods alextwoods enabled auto-merge June 25, 2025 15:15
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@alextwoods alextwoods added this pull request to the merge queue Jun 25, 2025
Merged via the queue into master with commit 61a8bba Jun 25, 2025
33 of 34 checks passed
@github-actions
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2025
@alextwoods alextwoods deleted the alexwoo/protocol-test-error-cases branch August 15, 2025 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

changelog-not-required Indicate changelog entry is not required for a specific PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants