Skip to content

Remove paths filter from GH action items #6209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

Remove paths filter from GH action items #6209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b269163
Remove paths filter from serveral GH action items
zoewangg Jun 25, 2025
d6ebe44
Improve changelog-verification yml
zoewangg Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/api-surface-area-review-verification.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ on:
types: [ opened, synchronize, reopened, labeled, unlabeled ]
branches:
- master
paths:
- '**/*.java'

jobs:
api-surface-area-review-verification:
Expand Down
29 changes: 17 additions & 12 deletions .github/workflows/changelog-verification.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ on:
types: [ opened, synchronize, reopened, labeled, unlabeled ]
branches:
- master
paths:
- '**/*.java'

jobs:
changelog-verification:
Expand All @@ -21,20 +19,27 @@ jobs:
if: ${{ !contains(github.event.pull_request.labels.*.name, 'changelog-not-required') }}
run: |
git fetch origin ${{ github.base_ref }} --depth 1
NON_TEST_FILES=$( git diff remotes/origin/${{ github.base_ref }} --name-only | grep "\.java$" | grep -v -E "(^|/)(test|it)/" || true)
if [ -n "NON_TEST_FILES" ]; then
echo "::error::Non-test Java change found:"
echo "NON_TEST_FILES" | while read file; do
echo "::error::$file"
NON_TEST_FILES=$(git diff remotes/origin/${{ github.base_ref }} --name-only | grep "\.java$" | grep -v -E "(^|/)(test|it)/" || true)
if [ -n "$NON_TEST_FILES" ]; then
echo "::notice::Non-test Java changes found:"
echo "$NON_TEST_FILES" | while read file; do
echo "::notice::$file"
done
git diff remotes/origin/${{ github.base_ref }} --name-only | grep -P "\.changes/next-release/*[a-zA-Z0-9_-]+\.json"
echo "Checking for changelog entry..."
CHANGELOG_FILES=$(git diff remotes/origin/${{ github.base_ref }} --name-only | grep -P "\.changes/next-release/.*[a-zA-Z0-9_-]+\.json" || true)
if [ -z "$CHANGELOG_FILES" ]; then
echo "::error::No changelog entry found for Java changes"
exit 1
else
echo "::notice::Changelog entry found: $CHANGELOG_FILES"
fi
else
echo "No change that may require a changelog entry found."
echo "::notice::No non-test Java changes found. Changelog verification skipped."
fi
- name: Error message
if: ${{ failure() }}
run: |
echo "::error ::No new/updated changelog entry found in /.changes/next-release directory. Please either:"
echo "::error ::* Add a changelog entry (see CONTRIBUTING.md for instructions) –or–"
echo "::error ::* Add the 'changelog-not-required' label to this PR (in rare cases not warranting a changelog entry)"
echo "::error::No new/updated changelog entry found in /.changes/next-release directory. Please either:"
echo "::error::* Add a changelog entry (see CONTRIBUTING.md for instructions) –or–"
echo "::error::* Add the 'changelog-not-required' label to this PR (in rare cases not warranting a changelog entry)"
exit 1
3 changes: 0 additions & 3 deletions .github/workflows/new-module-verification.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ on:
branches:
- master
- feature/master/*
paths:
- '**/*.xml'
- '.brazil.json'

permissions:
contents: read
Expand Down
Loading