Skip to content

fixed the bug of EmfMetricLoggingPublisher not properly publishing Long metrics #6210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2025

Conversation

Fred1155
Copy link
Contributor

Motivation and Context

Customer reported that the Long metric cannot be published in EmfMetricLoggingPublisher because the original implementation directly cast the Long to Integer, which will result in an error.

Modifications

Changed the MetricEmfConverter class to write Long value using JsonWriter.writeValue(Long) method.

Testing

Added unit test case

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@Fred1155 Fred1155 requested a review from a team as a code owner June 25, 2025 19:09
@Fred1155 Fred1155 added the changelog-not-required Indicate changelog entry is not required for a specific PR label Jun 25, 2025
Copy link
Contributor

@zoewangg zoewangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change log entry is required though since this is a bug fix. It's not required only for non-customer facing changes, for example, adding tests, updating docs or updating GH workflow.

The change itself lgtm

@Fred1155 Fred1155 requested a review from zoewangg June 25, 2025 20:20
@Fred1155 Fred1155 removed the changelog-not-required Indicate changelog entry is not required for a specific PR label Jun 25, 2025
@Fred1155 Fred1155 enabled auto-merge June 25, 2025 20:30
@Fred1155 Fred1155 added this pull request to the merge queue Jun 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 25, 2025
@Fred1155 Fred1155 added this pull request to the merge queue Jun 25, 2025
@Fred1155 Fred1155 removed this pull request from the merge queue due to a manual request Jun 25, 2025
@Fred1155 Fred1155 enabled auto-merge June 25, 2025 22:24
Copy link

@Fred1155 Fred1155 added this pull request to the merge queue Jun 25, 2025
Merged via the queue into master with commit cf5a2ba Jun 26, 2025
34 of 35 checks passed
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2025
@Fred1155 Fred1155 deleted the bole/emf_long_fix branch June 26, 2025 03:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants