fixed the bug of EmfMetricLoggingPublisher not properly publishing Long metrics #6210
Merged
fixed the bug of EmfMetricLoggingPublisher not properly publishing Long metrics #6210
Conversation
zoewangg
reviewed
Jun 25, 2025
Contributor
zoewangg
left a comment
There was a problem hiding this comment.
Change log entry is required though since this is a bug fix. It's not required only for non-customer facing changes, for example, adding tests, updating docs or updating GH workflow.
The change itself lgtm
zoewangg
approved these changes
Jun 25, 2025
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation and Context
Customer reported that the Long metric cannot be published in EmfMetricLoggingPublisher because the original implementation directly cast the Long to Integer, which will result in an error.
Modifications
Changed the MetricEmfConverter class to write Long value using JsonWriter.writeValue(Long) method.
Testing
Added unit test case
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License