Skip to content

Handled Surface API review comments #6224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2025

Conversation

joviegas
Copy link
Contributor

@joviegas joviegas commented Jul 1, 2025

Handled Surface API review comments

Motivation and Context

This change adds support for configuring a local address in the Apache5 HTTP client, bringing it to feature parity with the Apache HTTP client.

Modifications

  1. Added local address configuration to Apache5HttpClient:

    • Added localAddress field to the DefaultBuilder class
    • Added localAddress(InetAddress) method to the Builder interface
    • Added setter method setLocalAddress(InetAddress) for bean-style configuration
    • Modified addProxyConfig() to handle local address configuration when no custom route planner is provided
  2. Updated client name:

    • Changed CLIENT_NAME from "Apache5" to "Apache5Preview" to identify Preview in user agents
  3. Added test coverage:

    • Created Apache5HttpClientLocalAddressOnBuilderFunctionalTest to test local address configuration via builder
    • Renamed existing test to Apache5HttpClientLocalAddressRoutePlannerFunctionalTest for clarity
    • Updated MetricReportingTest to expect the new client name
  4. Package name consistency:

    • Updated .brazil.json to use consistent casing: AwsJavaSdk-HttpClient-Apache5Client-Preview

Testing

License

  • I confirm that this pull request can be released under the Apache 2 license

@joviegas joviegas requested a review from a team as a code owner July 1, 2025 22:02
@joviegas joviegas force-pushed the joviegas/post-surface-api-review branch from 7b08f1d to 1b1caa0 Compare July 1, 2025 22:03
Copy link

sonarqubecloud bot commented Jul 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
63.2% Coverage on New Code (required ≥ 80%)
18.1% Duplication on New Code (required ≤ 3%)
B Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@joviegas joviegas merged commit 4aa1fdb into feature/master/apache5x Jul 3, 2025
26 of 27 checks passed
Copy link

github-actions bot commented Jul 3, 2025

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants