Skip to content

Throw ModelInvalidException for bearerAuth issues #6229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Jul 2, 2025

Change from IllegalStateException to ModelInvalidException for cases where the enableEnvironmentBearerToken customization is enabled but the service model does not support it.

This commit adds a new error ID INVALID_CODEGEN_CUSTOMIZATION for these cases.

Motivation and Context

Modifications

Testing

Tested locally with an invalid service model and ensured that

  • the new exceptions are thrown
  • the generated validation-report.json contains the expected issues

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir requested a review from a team as a code owner July 2, 2025 22:53
Change from IllegalStateException to ModelInvalidException for cases
where the enableEnvironmentBearerToken customization is enabled but the
service model does not support it.

This commit adds a new error ID `INVALID_CODEGEN_CUSTOMIZATION` for
these cases.
@dagnir dagnir force-pushed the dongie/enableEnvironmentBearerToken-validation branch from dab57bd to dccfedb Compare July 2, 2025 22:55
Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM - just minor validation wording

@dagnir dagnir enabled auto-merge July 2, 2025 23:06
@dagnir dagnir added this pull request to the merge queue Jul 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 3, 2025
@dagnir dagnir added this pull request to the merge queue Jul 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 3, 2025
@dagnir dagnir enabled auto-merge July 3, 2025 20:00
Copy link

sonarqubecloud bot commented Jul 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
12.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@dagnir dagnir added this pull request to the merge queue Jul 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2025
@dagnir dagnir added this pull request to the merge queue Jul 3, 2025
Merged via the queue into master with commit ee827e1 Jul 3, 2025
38 of 39 checks passed
Copy link

github-actions bot commented Jul 3, 2025

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants