Skip to content

Add Query Compatible protocol tests #6230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 4, 2025

Conversation

alextwoods
Copy link
Contributor

Adds java flavored query compatible protocol tests ported from Smithy.

Motivation and Context

Improve test coverage for query compatibility by porting Smithy protocol tests.

Modifications

  • Add support for new (optional) protocol test fields:
    • id
    • errorCode
  • Port query compatibility tests from smithy

Testing

Run all protocol tets.

Screenshots (if appropriate)

Types of changes

NA - additional tests only - no SDK behavior changes.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods requested a review from a team as a code owner July 3, 2025 16:31
@alextwoods alextwoods added the changelog-not-required Indicate changelog entry is not required for a specific PR label Jul 3, 2025
Copy link

sonarqubecloud bot commented Jul 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@alextwoods alextwoods added this pull request to the merge queue Jul 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2025
@zoewangg zoewangg added this pull request to the merge queue Jul 4, 2025
Merged via the queue into master with commit 4bf8e38 Jul 4, 2025
41 of 42 checks passed
Copy link

github-actions bot commented Jul 4, 2025

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2025
@davidh44 davidh44 deleted the feature/master/query-compatible-protocol-tests branch July 7, 2025 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog-not-required Indicate changelog entry is not required for a specific PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants