Fix classloading in ConstructorCache #6233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
force-pushed
the
dongie/constructor-cache-classloader-fix
branch
from
0e72cfc to
a23083c
Compare
millems
approved these changes
Jul 7, 2025
dagnir
force-pushed
the
dongie/constructor-cache-classloader-fix
branch
2 times, most recently
from
088f711 to
808e14f
Compare
dagnir
force-pushed
the
dongie/constructor-cache-classloader-fix
branch
from
1ca6200 to
da05816
Compare
Use the SDK standard ClassLoaderHelper#getClass to try and load the given class from a ClassLoader. Previously, we were only looking at the ClassLoader returned by ClassLoaderHelper#contextClassLoader which either returns the Thread's context ClassLoader, or the system ClassLoader if that isn't present. This is an issue because it's possible that neither of these ClassLoaders are correct; we should also be looking at the ClassLoader that loaded the calling class. As part of this change, the internal Map used in ConstructorCache has been changed. Rather than doing a two-level mapping from String -> (Map of ClassLoader to Class), we have a single level mapping from String -> Class. Class is still referenced via a WeakReference so it is still free to be GC'd at any point.
dagnir
force-pushed
the
dongie/constructor-cache-classloader-fix
branch
from
da05816 to
2bf381f
Compare
millems
approved these changes
Jul 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the SDK standard ClassLoaderHelper#getClass to try and load the given class from a ClassLoader.
Previously, we were only looking at the ClassLoader returned by ClassLoaderHelper#contextClassLoader which either returns the Thread's context ClassLoader, or the system ClassLoader if that isn't present. This is an issue because it's possible that neither of these ClassLoaders are correct; we should also be looking at the ClassLoader that loaded the calling class.
As part of this change, the internal Map used in ConstructorCache has been changed. Rather than doing a two-level mapping from String -> (Map of ClassLoader to Class), we have a single level mapping from String -> Class. Class is still referenced via a WeakReference so it is still free to be GC'd at any point.
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License