Fix service version info to only register major and minor versions #6261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanVaknin
added
the
changelog-not-required
RanVaknin
changed the title
alextwoods
approved these changes
Jul 15, 2025
| public class VersionUtilsTest { | ||
|
|
||
| @Test | ||
| public void serviceVersionInfo_redactPatchVersion() { |
There was a problem hiding this comment.
probably worth adding a test case for versiosn that don't match the regex + a non 2.x version
zoewangg
approved these changes
Jul 15, 2025
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #6212
Changes
ServiceVersionInfoto be generated with amajor.minor.xformat instead ofmajor.minor.patchthis is to avoid updating this file for every service for every release.Lowering the update cadence is done to avoid rate limiting in our release infrastructure. This comes at the cost of having less fine-grained useragent info.