Skip to content

Fix protocol dependencies for smithy-rpc-v2-cbor when creating new service module #6265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025

Conversation

alextwoods
Copy link
Contributor

Fix protocol dependencies for smithy-rpc-v2-cbor when creating new service module

Motivation and Context

When new modules are created for rpcv2 cbor services we are currently incorrectly specifing the protocol dependency in the pom.xml, example error:

 Could not resolve dependencies for project software.amazon.awssdk:XXXXXXX:jar:2.32.3-SNAPSHOT: Could not find artifact software.amazon.awssdk:aws-smithy-rpc-v2-cbor-protocol:jar:2.32.3-SNAPSHOT

This is because the protocol name used in transformSpecialProtocols for rpcv2 is incorrect. The correct value for the protocol from c2j files is smithy-rpc-v2-cbor.

Modifications

Testing

Manual testing.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods requested a review from a team as a code owner July 16, 2025 20:49
@alextwoods alextwoods added the changelog-not-required Indicate changelog entry is not required for a specific PR label Jul 16, 2025
@alextwoods alextwoods added the no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required label Jul 16, 2025
@alextwoods
Copy link
Contributor Author

Surface area API review is incorrectly flagging this as a change to a public/protected API - this is a change to only the constant used for substitution of protocol dependencies when creating new service modules.

@alextwoods alextwoods enabled auto-merge July 16, 2025 20:56
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@alextwoods alextwoods added this pull request to the merge queue Jul 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 16, 2025
@alextwoods alextwoods added this pull request to the merge queue Jul 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 16, 2025
@alextwoods alextwoods added this pull request to the merge queue Jul 17, 2025
Merged via the queue into master with commit ecb18c1 Jul 17, 2025
45 of 48 checks passed
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2025
@alextwoods alextwoods deleted the alexwoo/fix-cbor-dep branch August 15, 2025 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog-not-required Indicate changelog entry is not required for a specific PR no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants