Convert some codegen exceptions to ModelInvalidException#6274
Merged
alextwoods merged 3 commits intomasterfrom Jul 18, 2025
Merged
Convert some codegen exceptions to ModelInvalidException#6274alextwoods merged 3 commits intomasterfrom
alextwoods merged 3 commits intomasterfrom
Conversation
zoewangg
approved these changes
Jul 17, 2025
codegen/src/main/java/software/amazon/awssdk/codegen/naming/DefaultNamingStrategy.java
Outdated
Show resolved
Hide resolved
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Converts some codegen exceptions to ModelInvalidException.
Motivation and Context
Related previous change: https://github.com/aws/aws-sdk-java-v2/pull/new/alexwoo/model-validations
There are a number of places we raise NPE or IllegalArgumentException, ect when there are issues with customization config or the model - this PR converts those exceptions to the new ModelInvalidException.
Modifications
Testing
existing test cases
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License