Skip to content

Fix dependency generation for new smithy-rpc-v2-cbor services #6276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025

Conversation

alextwoods
Copy link
Contributor

Fix dependency generation for new smithy-rpc-v2-cbor services

Motivation and Context

Generation of new smithy-rpc-v2-cbor services is failing with:

[WARNING] Used undeclared dependencies found:
[WARNING]    software.amazon.awssdk:aws-json-protocol:jar:2.32.4-SNAPSHOT:compile

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.1.1:analyze-only (default) on project arcregionswitch: Dependency problems found

While the aws-cbor-protocol module does define a dependency on aws-json-protocol, the code generation also generates code into the service module that has direct dependencies on aws-json-protocol, causing the undeclared dependencies issue above.

Modifications

  • Adds a static map of additional dependencies per protocol that are added to the list.

Testing

Manual testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods requested a review from a team as a code owner July 17, 2025 23:12
@alextwoods alextwoods added the changelog-not-required Indicate changelog entry is not required for a specific PR label Jul 17, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
60.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@alextwoods alextwoods added the no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required label Jul 18, 2025
@alextwoods alextwoods added this pull request to the merge queue Jul 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 18, 2025
@alextwoods alextwoods added this pull request to the merge queue Jul 18, 2025
Merged via the queue into master with commit dd3571f Jul 18, 2025
43 of 46 checks passed
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2025
@alextwoods alextwoods deleted the alexwoo/fix-rpcv2-cbor-deps branch August 15, 2025 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog-not-required Indicate changelog entry is not required for a specific PR no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants