Move connection timeout configuration from RequestConfig to ConnectionConfig in Apache HttpClient 5

[joviegas]

Motivation and Context

This change addresses the use of deprecated APIs in Apache HttpClient 5. The setConnectTimeout() method in RequestConfig.Builder is deprecated and should be replaced with proper connection-level timeout configuration via ConnectionConfig.

In Apache HttpClient 5, the architecture separates:

• Connection-level timeouts (connect timeout, socket timeout, TTL) → configured via ConnectionConfig
• Request-level timeouts (connection request timeout, response timeout) → configured via RequestConfig

This change aligns our implementation with Apache HttpClient 5's recommended practices and eliminates deprecated API usage warnings.

Modifications

• Removed connectionTimeout from Apache5HttpRequestConfig - This timeout is now managed at the connection manager level
• Added getConnectionConfig() method in ApacheConnectionManagerFactory to centralize connection-level timeout configuration
• Moved connection timeout, socket timeout, and TTL configuration to ConnectionConfig instead of RequestConfig
• Updated addRequestConfig() method in Apache5HttpRequestFactory to remove deprecated setConnectTimeout() call
• Updated all test files to remove references to connection timeout in request configuration
• Added timeout validation tests to ensure both connection and socket timeouts work correctly

Testing

• Added connectionTimeout_exceedsLimit_throwsException() test - Validates connection timeout using non-routable IP address (192.0.2.1) with 100ms timeout
• Added socketTimeout_exceedsLimit_throwsException() test - Validates socket timeout using WireMock with 2-second delay and 500ms timeout
• Updated existing tests - Removed connection timeout configuration from MetricReportingTest and ApacheHttpRequestFactoryTest
• Verified backward compatibility - All existing functionality continues to work, timeouts are just configured at the appropriate architectural level
• Cross-platform compatibility - Tests account for different exception messages across JVM implementations using multiple timeout-related keywords

The tests confirm that:

1. Connection timeouts are properly enforced when connecting to unreachable endpoints
2. Socket timeouts are properly enforced when waiting for slow server responses
3. The timeout configuration at the ConnectionConfig level works as expected
4. No regression in existing timeout functionality

Screenshots (if appropriate)

• I confirm that this pull request can be released under the Apache 2 license

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[dagnir]

minor: looks like we can just use Timeout.ofMilliseconds so this is less verbose

[joviegas]

done

[github-actions]

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.