Merged
Conversation
joviegas
added
the
no-api-surface-area-change
dagnir
reviewed
Jul 25, 2025
| * in exchange for more functionality, like support for HTTP proxies. | ||
| * | ||
| * <p>See software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient for an alternative implementation.</p> | ||
| * <p><b>Note:</b> The higher startup latency is compared to UrlConnectionHttpClient, not to the Apache HttpClient 4.5.x |
Contributor
There was a problem hiding this comment.
I don't think this line is necessary. We already state above:
and higher startup latency compared to UrlConnectionHttpClient
| * | ||
| * <p>See software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient for an alternative implementation.</p> | ||
| * <p><b>Note:</b> The higher startup latency is compared to UrlConnectionHttpClient, not to the Apache HttpClient 4.5.x | ||
| * based client. Performance characteristics between Apache 4.5.x and 5.x clients are similar.</p> |
Contributor
There was a problem hiding this comment.
Move the "Performance characteristics..." after the list of improvements.
dagnir
approved these changes
Jul 28, 2025
|
joviegas
added
the
changelog-not-required
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Update Java docs for Apache Clients , for slow latency do a comparison with SDK Url connection explicitly in java docs
Modifications
License