Skip to content

Update Java docs for Apache Clients #6299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025
Merged

Conversation

joviegas
Copy link
Contributor

Motivation and Context

Update Java docs for Apache Clients , for slow latency do a comparison with SDK Url connection explicitly in java docs

Modifications

License

  • I confirm that this pull request can be released under the Apache 2 license

@joviegas joviegas requested a review from a team as a code owner July 25, 2025 15:03
@joviegas joviegas added the no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required label Jul 25, 2025
*
* <p>See software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient for an alternative implementation.</p>
* <p><b>Note:</b> The higher startup latency is compared to UrlConnectionHttpClient, not to the Apache HttpClient 4.5.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this line is necessary. We already state above:

and higher startup latency compared to UrlConnectionHttpClient

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

*
* <p>See software.amazon.awssdk.http.urlconnection.UrlConnectionHttpClient for an alternative implementation.</p>
* <p><b>Note:</b> The higher startup latency is compared to UrlConnectionHttpClient, not to the Apache HttpClient 4.5.x
* based client. Performance characteristics between Apache 4.5.x and 5.x clients are similar.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the "Performance characteristics..." after the list of improvements.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link

@joviegas joviegas added this pull request to the merge queue Jul 29, 2025
@joviegas joviegas added the changelog-not-required Indicate changelog entry is not required for a specific PR label Jul 29, 2025
Merged via the queue into master with commit b4fd74e Jul 29, 2025
38 of 41 checks passed
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2025
@joviegas joviegas deleted the joviegas/java_docs_apache4And5 branch August 15, 2025 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changelog-not-required Indicate changelog entry is not required for a specific PR no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants