Fix bug in MultipartS3AsyncClient GetObject

[davidh44]

Motivation and Context

This PR fixes a bug in the Java-based multipart S3 client (MultipartS3AsyncClient) that causes duplicate request logging when a retryable error occurs during many concurrent GetObject operations

Currently, when a retryable error, e.g., 503 Slowdown, is returned by S3, the SDK may do one of two things:

1. Fail the request right away instead of retrying
2. Retry the error, but incorrectly process subsequent responses. A successful 200 response returned by the sever will be ignored. Instead, the SDK will log the initial error, and continue to retry until retry attempts are exhausted. This may happen instead of scenario 1 (failing right away), if many concurrent requests are in progress and a race condition occurs.

This PR fixes 2), a follow up PR will fix 1)

Modifications

SplittingTransformer

• When completing the individualFuture exceptionally in the IndividualTransformer, wrap the exception with NonRetryableException

MultipartDownloaderSubscriber

• Keep track of each part GET request and cancel all in-flight ones if onError() is invoked

Testing

Added mock tests

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

[github-actions]

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.