Delete optimistic locking POC #6327
Open
+545
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
joviegas
commented
Aug 8, 2025
| @@ -37,14 +37,16 @@ | |||
| */ | |||
| @SdkPublicApi | |||
| @ThreadSafe | |||
| public final class TransactDeleteItemEnhancedRequest { | |||
| public final class TransactDeleteItemEnhancedRequest<T> { | |||
There was a problem hiding this comment.
This is backward incompatible change , just modified this for POC.
May be we can add a new class TransactDeleteCompleteItemEnhancedRequest or some good name and use this for specific case of optimistic delete case where we pass complete Items instead of just key.
joviegas
commented
Aug 8, 2025
| @@ -531,7 +531,7 @@ public void generateTransactWriteItem_returnValuesOnConditionCheckFailure_genera | |||
|
|
|||
| DeleteItemOperation<FakeItem> deleteItemOperation = | |||
| spy(DeleteItemOperation.create(TransactDeleteItemEnhancedRequest.builder() | |||
| .key(k -> k.partitionValue(fakeItem.getId())) | |||
| // .key(k -> k.partitionValue(fakeItem.getId())) | |||
There was a problem hiding this comment.
POC only , we should not comment this out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License