-
Notifications
You must be signed in to change notification settings - Fork 932
Fix ApacheHttpClient Proxy Preemptive Auth Failure #6333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextwoods
reviewed
Aug 12, 2025
...ache-client/src/main/java/software/amazon/awssdk/http/apache/internal/utils/ApacheUtils.java
Show resolved
Hide resolved
RanVaknin
requested changes
Aug 13, 2025
.../apache-client/src/test/java/software/amazon/awssdk/http/apache/ProxyPreemptiveAuthTest.java
Outdated
Show resolved
Hide resolved
.../apache-client/src/test/java/software/amazon/awssdk/http/apache/ProxyPreemptiveAuthTest.java
Outdated
Show resolved
Hide resolved
.../apache-client/src/test/java/software/amazon/awssdk/http/apache/ProxyPreemptiveAuthTest.java
Outdated
Show resolved
Hide resolved
RanVaknin
requested changes
Aug 13, 2025
.../apache-client/src/test/java/software/amazon/awssdk/http/apache/ProxyPreemptiveAuthTest.java
Outdated
Show resolved
Hide resolved
|
RanVaknin
approved these changes
Aug 13, 2025
alextwoods
approved these changes
Aug 13, 2025
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ApacheHttpClient proxy authentication failure issue with preemptive authentication.
Motivation and Context
Users configuring proxy preemptive authentication with preemptiveBasicAuthenticationEnabled set to true were experiencing 407 error which was not expected.
Fixes #5884
Modifications
Added synthetic challenge processing in addPreemptiveAuthenticationProxy() method to initialize BasicScheme for preemptive authentication
Testing
Added unit test to verify preemptive authentication functionality
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License