Event stream response handler builder onError documentation improvement#6340
Merged
Event stream response handler builder onError documentation improvement#6340
Conversation
…the callback may be called multiple time, similarly to the exceptionOccurred method
alextwoods
approved these changes
Aug 13, 2025
|
L-Applin
added
the
no-api-surface-area-change
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve
EventStreamResponseHandler.Builder.onErrorjavadoc to mention that the callback may be called multiple time, similarly to the exceptionOccurred method.The default implementation of the
exceptionOccurredsimply calls the consumer passed to theonError(Consumer)method of the builder. TheexceptionOccurredalready mentions that it can be called multiple time, but theonErrormethod of the builder was not.