Avoid extra byte array copying when downloading to memory with AsyncResponseTransformer #6348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponseTransformer
dagnir
approved these changes
Aug 14, 2025
joviegas
reviewed
Aug 14, 2025
| @@ -47,7 +47,7 @@ public final class ByteArrayAsyncResponseTransformer<ResponseT> implements | |||
| @Override | |||
| public CompletableFuture<ResponseBytes<ResponseT>> prepare() { | |||
| cf = new CompletableFuture<>(); | |||
| return cf.thenApply(arr -> ResponseBytes.fromByteArray(response, arr)); | |||
| return cf.thenApply(arr -> ResponseBytes.fromByteArrayUnsafe(response, arr)); | |||
There was a problem hiding this comment.
It would be great if we add a comment over here on why we are using fromByteArrayUnsafe for future references (while doing code walks)
There was a problem hiding this comment.
sure, added comment
davidh44
added
the
api-surface-area-approved-by-team
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
davidh44
deleted the
hdavidh/async-response-transformer-to-bytes-avoid-extra-copy
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently
ByteArrayAsyncResponseTransformerinvokesResponseBytes.fromByteArray()once all the data is downloaded, which copies the contents of the byte array when creatingResponseBytesModifications
replace
ResponseBytes.fromByteArray()withResponseBytes.fromByteArrayUnsafe(), which createsResponseByteswithout copying the contents of the byte arrayTesting
Performance tests showed increased throughput and decrease in latency
Screenshots (if appropriate)
Types of changes