-
Notifications
You must be signed in to change notification settings - Fork 932
Fix DDB Enhanced Client immutable class introspection fails for "is" prefix fields #6349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
S-Saranya1
merged 2 commits into
master
from
somepal/ddb-enhanced-immutable-is-prefix-fix
Aug 15, 2025
+181
−0
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"type": "bugfix", | ||
"category": "AWS SDK for Java v2", | ||
"contributor": "", | ||
"description": "Fix DynamoDB Enhanced Client immutable class introspection fails for \"is\" prefix fields. Fixes [#4446](https://github.com/aws/aws-sdk-java-v2/issues/4446)." | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95 changes: 95 additions & 0 deletions
95
.../src/test/java/software/amazon/awssdk/enhanced/dynamodb/ImmutableBooleanIsPrefixTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
/* | ||
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* A copy of the License is located at | ||
* | ||
* http://aws.amazon.com/apache2.0 | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed | ||
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
* express or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
package software.amazon.awssdk.enhanced.dynamodb; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
|
||
import org.junit.Test; | ||
import software.amazon.awssdk.enhanced.dynamodb.mapper.annotations.DynamoDbImmutable; | ||
import software.amazon.awssdk.enhanced.dynamodb.mapper.annotations.DynamoDbPartitionKey; | ||
|
||
/** | ||
* Tests that TableSchema.fromImmutableClass() works correctly with immutable classes | ||
* that have boolean fields using "is" prefix. | ||
*/ | ||
public class ImmutableBooleanIsPrefixTest { | ||
|
||
@DynamoDbImmutable(builder = Car.Builder.class) | ||
public static final class Car { | ||
private final String licensePlate; | ||
private final boolean isRusty; | ||
private final boolean isImpounded; | ||
|
||
private Car(Builder b) { | ||
this.licensePlate = b.licensePlate; | ||
this.isRusty = b.isRusty; | ||
this.isImpounded = b.isImpounded; | ||
} | ||
|
||
@DynamoDbPartitionKey | ||
public String licensePlate() { | ||
return this.licensePlate; | ||
} | ||
|
||
public boolean isRusty() { | ||
return this.isRusty; | ||
} | ||
|
||
public boolean isImpounded() { | ||
return this.isImpounded; | ||
} | ||
|
||
public static final class Builder { | ||
private String licensePlate; | ||
private boolean isRusty; | ||
private boolean isImpounded; | ||
|
||
public Builder licensePlate(String licensePlate) { | ||
this.licensePlate = licensePlate; | ||
return this; | ||
} | ||
|
||
public Builder isRusty(boolean isRusty) { | ||
this.isRusty = isRusty; | ||
return this; | ||
} | ||
|
||
public Builder isImpounded(boolean isImpounded) { | ||
this.isImpounded = isImpounded; | ||
return this; | ||
} | ||
|
||
public Car build() { | ||
return new Car(this); | ||
} | ||
} | ||
} | ||
|
||
@Test | ||
public void fromImmutableClass_withIsPrefixBooleanSetters_shouldCreateSchemaSuccessfully() { | ||
// This should work without exception | ||
TableSchema<Car> schema = TableSchema.fromImmutableClass(Car.class); | ||
|
||
// Verify the schema was created successfully without exception | ||
assertThat(schema).isNotNull(); | ||
assertThat(schema.itemType().rawClass()).isEqualTo(Car.class); | ||
|
||
// Verify all attributes are mapped correctly | ||
assertThat(schema.attributeNames()).containsExactlyInAnyOrder( | ||
"licensePlate", "rusty", "impounded" | ||
); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.