Avoid extra byte array copying when downloading to memory with AsyncResponseTransformer

[davidh44]

Motivation and Context

Follow up to #6348

More optimizations in ByteArrayAsyncResponseTransformer to avoid unnecessary copying of data

Modifications

• Replace future return type of byte[] to ByteBuffer in ByteArrayAsyncResponseTransformer
• New subclass DirectAccessByteArrayOutputStream that extends ByteArrayOutputStream, with method toByteBuffer() to access the internal buffer directly without copying
• New method ResponseBytes.fromByteBufferUnsafe() to create ResponseBytes from ByteBuffer without copying

ByteArrayAsyncResponseTransformer.BaosSubscriber

• in onNext(), if byteBuffer.hasArray() is true, then we can safely invoke byteBuffer.array() and directly write the content to ByteArrayOutputStream instead of copying the bytes with BinaryUtils.copyBytesFrom()
• in onComplete(), get the internal buffer from DirectAccessByteArrayOutputStream without copying, using toByteBuffer() instead of toByteArray()

Testing

Added unit tests
Existing tests passing
Performance tests showed increased throughput and decrease in latency

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

[sonarqubecloud]

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.