Avoid extra byte array copying when downloading to memory with AsyncResponseTransformer #6355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Motivation and Context
Follow up to #6348
More optimizations in
ByteArrayAsyncResponseTransformerto avoid unnecessary copying of dataModifications
byte[]toByteBufferinByteArrayAsyncResponseTransformerDirectAccessByteArrayOutputStreamthat extendsByteArrayOutputStream, with methodtoByteBuffer()to access the internal buffer directly without copyingResponseBytes.fromByteBufferUnsafe()to createResponseBytesfromByteBufferwithout copyingByteArrayAsyncResponseTransformer.BaosSubscriberonNext(), ifbyteBuffer.hasArray()is true, then we can safely invokebyteBuffer.array()and directly write the content toByteArrayOutputStreaminstead of copying the bytes withBinaryUtils.copyBytesFrom()onComplete(), get the internal buffer fromDirectAccessByteArrayOutputStreamwithout copying, usingtoByteBuffer()instead oftoByteArray()Testing
Added unit tests
Existing tests passing
Performance tests showed increased throughput and decrease in latency
Screenshots (if appropriate)
Types of changes