Merged
Conversation
181a23a to
7150b6c
Compare
In DynamoDB, the "NULL" member of AttributeValue is customized to "NUL" because "null" is a reserved keyword. This has the effect of generating nul() and getNul() as getters, and nul(Boolean), and setNul(Boolean) as setters for the serializable builder class. If using the serializable builder class to map from a JSON string with the correct property name "NULL", it will not be recognized. To fix this, generate an additional setter with the correct name getNull(). To make this work, `ModifyModelShapeModifier` has been updated with a new option called `alternateBeanPropertyName`. When set, for the modified member, we will generate an additional bean style setter on the model builder using the given property name.
7150b6c to
079a67c
Compare
zoewangg
requested changes
Aug 21, 2025
...java/software/amazon/awssdk/codegen/model/config/customization/ModifyModelShapeModifier.java
Show resolved
Hide resolved
zoewangg
approved these changes
Aug 21, 2025
...en/src/test/resources/software/amazon/awssdk/codegen/poet/model/containsreservedkeyword.java
Show resolved
Hide resolved
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation and Context
In DynamoDB, the "NULL" member of AttributeValue is customized to "NUL" because "null" is a reserved keyword. This has the effect of generating nul() and getNul() as getters, and nul(Boolean), and setNul(Boolean) as setters for the serializable builder class.
If using the serializable builder class to map from a JSON string with the correct property name "NULL", it will not be recognized.
To fix this, generate an additional setter with the correct name setNull().
To make this work,
ModifyModelShapeModifierhas been updated with a new option calledalternateBeanPropertyName. When set, for the modified member, we will generate an additional bean style setter on the model builder using the given property name.Diff of generated code. Adds a
setNullthat behaves exactly likesetNul.Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License