Add presigned URL download support to S3 Transfer Manager #6364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
davidh44
reviewed
Aug 25, 2025
| @@ -71,6 +73,8 @@ public static void setUpForAllIntegTests() throws Exception { | |||
| System.setProperty("aws.crt.debugnative", "true"); | |||
| s3 = s3ClientBuilder().build(); | |||
| s3Async = s3AsyncClientBuilder().build(); | |||
| s3multiAsync = s3AsyncClientBuilder().multipartEnabled(true).build(); | |||
There was a problem hiding this comment.
Redundant, s3AsyncClientBuilder() already sets multipartEnabled(true)
Comment on lines
+49
to
+52
| // Clamp transferredBytes to not exceed totalBytes to handle race conditions | ||
| if (builder.totalBytes != null && validatedTransferredBytes > builder.totalBytes) { | ||
| validatedTransferredBytes = builder.totalBytes; | ||
| } |
There was a problem hiding this comment.
Under what scenarios would this occur?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Adds
downloadFileWithPresignedUrlanddownloadWithPresignedUrlmethods to S3TransferManagerModifications
Added two new public API methods in S3TransferManager with consumer builder variants
Implemented presigned URL download logic in GenericS3TransferManager with multipart support and progress tracking
Enhanced PresignedUrlMultipartDownloaderSubscriber validation for small objects (size < configured part size)
Updated DefaultTransferProgressSnapshot to handle presigned URL requests
Added javadoc note that pause/resume is not supported
Testing
Integration test
S3TransferManagerPresignedUrlDownloadIntegrationTestUnit test
S3TransferManagerPresignedUrlDownloadTestfor core logic with mocksAlso added
AsyncPresignedUrlExtensionMultipartIntegrationTestIntegration tests for Multipart download for pre-signed URLsScreenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License