Rvaknin/revert 6295 lambda tracer #6366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanVaknin
commented
Aug 22, 2025
| <exclude>*.internal.*</exclude> | ||
| <exclude>software.amazon.awssdk.thirdparty.*</exclude> | ||
| <exclude>software.amazon.awssdk.regions.*</exclude> | ||
| <!-- TODO remove after release --> | ||
| <exclude>software.amazon.awssdk.awscore.interceptor.TraceIdExecutionInterceptor</exclude> |
There was a problem hiding this comment.
japicmp is flagging this as a breaking change, however this is an SdkProtectedApi class, and the removal is of override methods whose implementation was not supported server side.
|
zoewangg
approved these changes
Aug 22, 2025
RanVaknin
added
changelog-not-required
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting the PR since slf4j implementation for MDC.get() is not provided by the SDK or by the Lambda runtime by default. This will only work if users provide their own implementation and it defeats the purpose of this working on Lambda by default.