Add timeout to ResponseInputStream and ResponsePublisher #6367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred1155
reviewed
Aug 25, 2025
core/sdk-core/src/main/java/software/amazon/awssdk/core/ResponseInputStream.java
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/ResponseInputStream.java
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/ResponseInputStream.java
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/async/ResponsePublisher.java
Show resolved
Hide resolved
|
Fred1155
approved these changes
Aug 25, 2025
davidh44
added
the
api-surface-area-approved-by-team
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
davidh44
deleted the
hdavidh/add-timeout-response-publisher-and-inputStream
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#5355
Currently, when performing GET with
ResponseTransformer.toInputStream()orAsyncResponseTransformer.toPublisher(), the HTTP connection will remain open until the stream/publisher is consumed or canceled. If not properly handled, resource leakage can occur and subsequent requests may time out.Modifications
Add default timeout of 60 seconds for both
ResponseInputStreamandResponsePublisherAdd method overloads for
ResponseTransformer.toInputStream()andAsyncResponseTransformer.toPublisher()to take timeout arg of typeDurationTo disable timeout (existing behavior), pass
Duration.ZEROTesting
Added unit and integ tests
Screenshots (if appropriate)
Types of changes