Fix SqsAsyncBatchManager excessive batch flushing under heavy load (#6374) #6378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change enables the SqsAsyncBatchManager to make batches of correct size during high concurrency. More info in #6374
Modifications
I chose to synchronize the cancel and assignment of the scheduledFlush in RequestBatchBuffer.putScheduledFlush(). This is the only place this is used and it's an internal API, so I felt comfortable changing the name to make it more clear what it's doing.
Testing
Ran sample app used to reproduce the issue (found in bug report) and verified the average batch sizes were as expected with 500 TPS, 1000 TPS, 5000 TPS.
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License