Skip to content

Conversation

alextwoods
Copy link
Contributor

Set default for archetype credentialProvider parameter.

Motivation and Context

#3767 introduced a new parameter, credentialProvider to help control the dependencies generated. However, it did not specify a default value for it, leading existing usages of the tool to fail with a Property credentialProvider is missing error.

The README updated in #3767 does list the parameter as having a default value and not being required, so this PR simply sets that default value.

Modifications

Set default for archetype credentialProvider parameter.

Testing

Built archetype package locally and ran command using it without setting credentialProvider - command now succeeds.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods requested a review from a team as a code owner September 2, 2025 20:17
@alextwoods alextwoods added this pull request to the merge queue Sep 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2025
@alextwoods alextwoods added this pull request to the merge queue Sep 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 3, 2025
@alextwoods alextwoods added this pull request to the merge queue Sep 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2025
@alextwoods alextwoods added this pull request to the merge queue Sep 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2025
@alextwoods alextwoods enabled auto-merge September 4, 2025 18:49
Copy link

sonarqubecloud bot commented Sep 4, 2025

@alextwoods alextwoods added this pull request to the merge queue Sep 4, 2025
Merged via the queue into master with commit 17587f0 Sep 4, 2025
36 checks passed
Copy link

github-actions bot commented Sep 4, 2025

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2025
@alextwoods alextwoods deleted the alexwoo/archetype_default_credential_provider branch September 5, 2025 01:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants