Skip to content

Make test more reliable #6396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dagnir merged 2 commits into from
Sep 5, 2025
Merged

Make test more reliable #6396

dagnir merged 2 commits into from
Sep 5, 2025

Conversation

@dagnir
Copy link
Contributor

@dagnir dagnir commented Sep 4, 2025

  • Increase timeouts across the board to better ensure things are propagated
  • Separately wait for new credentials to become valid before moving on.

Motivation and Context

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir requested a review from a team as a code owner September 4, 2025 17:44
@dagnir dagnir added the changelog-not-required Indicate changelog entry is not required for a specific PR label Sep 4, 2025
@dagnir
Make test more reliable
be50163 
 - Increase timeouts across the board to better ensure things are
   propagated
 - Separately wait for new credentials to become valid before moving on.
@dagnir dagnir force-pushed the dongie/fix-flaky-test branch from 2efb79e to be50163 Compare September 4, 2025 17:50
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dagnir dagnir added this pull request to the merge queue Sep 4, 2025
Merged via the queue into master with commit e9ac904 Sep 5, 2025
38 of 39 checks passed
@github-actions
Copy link

github-actions bot commented Sep 5, 2025

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidh44 davidh44 davidh44 approved these changes

Assignees

No one assigned

Labels

changelog-not-required Indicate changelog entry is not required for a specific PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dagnir @davidh44