Fix flakey S3 Multipart tests #6399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-Applin
reviewed
Sep 4, 2025
|
|
||
| verify(1, getRequestedFor(urlEqualTo(String.format("/%s/%s?partNumber=1", BUCKET, errorKey)))); | ||
| verify(moreThan(0), getRequestedFor(urlEqualTo(String.format("/%s/%s?partNumber=1", BUCKET, errorKey)))); | ||
| verify(lessThanOrExactly(2), getRequestedFor(urlEqualTo(String.format("/%s/%s?partNumber=1", BUCKET, errorKey)))); |
Contributor
There was a problem hiding this comment.
Is requests 2 valid? Are we actually making an extra request or is it just a test issue?
Contributor
Author
There was a problem hiding this comment.
It should be one, but sometimes a second request is made in this test, likely due to the high volume of concurrent calls. The original issue was maxing out retries so this should still cover that case
L-Applin
approved these changes
Sep 4, 2025
davidh44
added
the
changelog-not-required
|
auto-merge was automatically disabled
September 4, 2025 23:20
Pull Request is not mergeable
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix flakey S3 Multipart GET tests
S3MultipartClientGetObjectRetryBehaviorWiremockTest
Status Code:to assertions as UUID may contain the error codeS3MultipartClientGetObjectWiremockTest