Reuse checksums in legacy signing codepath#6444
Merged
dagnir merged 2 commits intofeature/master/checksum-reusefrom Sep 26, 2025
Merged
Reuse checksums in legacy signing codepath#6444dagnir merged 2 commits intofeature/master/checksum-reusefrom
dagnir merged 2 commits intofeature/master/checksum-reusefrom
Conversation
7da4d9b to
f327336
Compare
f327336 to
5dc6463
Compare
This commit adds support for reusing calculated payload checksums over retries in the legacy (i.e. non-SRA) signing codepaths.
5dc6463 to
d7832d8
Compare
Fred1155
approved these changes
Sep 25, 2025
...c/main/java/software/amazon/awssdk/core/internal/http/pipeline/stages/HttpChecksumStage.java
Show resolved
Hide resolved
Fred1155
reviewed
Sep 25, 2025
Contributor
Fred1155
left a comment
There was a problem hiding this comment.
Do we plan to add integration test to test the retry behavior for reusing the checksum?
Contributor
Author
Good catch! We have mock HTTP client tests from a previous PR, but this is on on SRA. I'll add additional tests for non-SRA. |
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation and Context
This commit adds support for reusing calculated payload checksums over retries in the legacy (i.e. non-SRA) signing codepaths.
Builds on #6441.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License