Duplicate code reduction part 1: consolidate duplicate signing related classes #6480
+91
−286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidh44
approved these changes
Oct 15, 2025
zoewangg
force-pushed
the
zoewang/AddressDuplicateCodePart1
branch
from
2b36432 to
11f8a78
Compare
|
zoewangg
merged commit 8c81f83
into
feature/master/technicaldebt-duplicatecode
26 of 30 checks passed
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
There are a few duplicated signing related classes in
authandhttp-auth-awsmodule. This pull request intends to consolidate the ones that make sense including the following:auth, moved the one inhttp-auth-awsoutside of internal package, and marked it as protected APIutilsmodule and marked it as protected API because it is a generic util method that may be used elsewhere in the future.utilsmodule under internal subpackage, and kept it as private API