Skip to content

Conversation

@WillChilds-Klein
Copy link

@WillChilds-Klein WillChilds-Klein commented Oct 17, 2025

Motivation and Context

aws-crt-java v0.39.3 enables and prefers PQ by default for CRT HTTP clients.

Modifications

Bump CRT version, nothing else

Testing

  • CI

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
    • i see errors like below both with and without this PR's change
[ERROR] Failures:
[ERROR]   ServerConnectivityErrorMessageTest.closeTimeHasCorrectMessage:139 [Closing time: DURING_INIT]
Expecting throwable message:
  "Connection reset"
to contain:
  "The connection was closed during the request."
but did not.

Throwable that failed the check:

java.net.SocketException: Connection reset
        at java.base/sun.nio.ch.SocketChannelImpl.throwConnectionReset(SocketChannelImpl.java:394)
        at java.base/sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:426)
        at io.netty.buffer.PooledByteBuf.setBytes(PooledByteBuf.java:255)
        at io.netty.buffer.AbstractByteBuf.writeBytes(AbstractByteBuf.java:1132)
        at io.netty.channel.socket.nio.NioSocketChannel.doReadBytes(NioSocketChannel.java:356)
        at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:151)
        at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:796)
        at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:732)
        at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:658)
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562)
        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:998)
        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
        at java.base/java.lang.Thread.run(Thread.java:840)

[INFO]
[ERROR] Tests run: 421, Failures: 1, Errors: 0, Skipped: 1
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
    • it looks like this is no longer used/maintained
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

aws-crt-java [v0.39.3 enables](awslabs/aws-crt-java@7f0e2b8) and prefers PQ by default for CRT HTTP clients.
@WillChilds-Klein WillChilds-Klein marked this pull request as ready for review October 20, 2025 18:41
@WillChilds-Klein WillChilds-Klein requested a review from a team as a code owner October 20, 2025 18:41
@zoewangg
Copy link
Contributor

Closing in favor of #6490

@zoewangg zoewangg closed this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants