Reusing common logic#6491
Merged
zoewangg merged 1 commit intofeature/master/technicaldebt-duplicatecodefrom Oct 21, 2025
Merged
Reusing common logic#6491zoewangg merged 1 commit intofeature/master/technicaldebt-duplicatecodefrom
zoewangg merged 1 commit intofeature/master/technicaldebt-duplicatecodefrom
Conversation
|
L-Applin
reviewed
Oct 21, 2025
core/auth-crt/src/main/java/software/amazon/awssdk/authcrt/signer/internal/SigningUtils.java
Show resolved
Hide resolved
S-Saranya1
approved these changes
Oct 21, 2025
L-Applin
approved these changes
Oct 21, 2025
zoewangg
merged commit 325bfcf
into
feature/master/technicaldebt-duplicatecode
27 of 30 checks passed
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Reduce duplicate code/logic
Modifications
SdkLengthAwareInputStreamto utils and made it a protected API