Move ApplyUserAgentStage to later stage in request pipeline#6513
Merged
S-Saranya1 merged 4 commits intomasterfrom Oct 24, 2025
Merged
Move ApplyUserAgentStage to later stage in request pipeline#6513S-Saranya1 merged 4 commits intomasterfrom
S-Saranya1 merged 4 commits intomasterfrom
Conversation
zoewangg
reviewed
Oct 23, 2025
...classes-test/src/test/java/software/amazon/awssdk/services/BusinessMetricsUserAgentTest.java
Outdated
Show resolved
Hide resolved
joviegas
approved these changes
Oct 24, 2025
zoewangg
approved these changes
Oct 24, 2025
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Move ApplyUserAgentStage to later stage in request pipeline
Motivation and Context
Currently facing issue in few stages (like CompressRequestStage and HttpChecksumStage) where business metrics are recorded after User-Agent is finalized, causing metrics to not appear in the header. Moving ApplyUserAgentStage later in the pipeline will eliminate this issue.
Modifications
Moved ApplyUserAgentStage to execute after HttpChecksumStage in the request pipeline in AmazonSyncHttpClient and AmazonAsyncHttpClient.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License