Merged
Conversation
RanVaknin
commented
Oct 30, 2025
| public void setup() { | ||
| jsonGenerator = new SdkJsonGenerator(JsonFactory.builder().build(), "application/json"); | ||
| jsonGenerator = new SdkJsonGenerator(JsonFactory.builder() | ||
| .enable(StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION) |
Contributor
Author
There was a problem hiding this comment.
jackson 2.16.0 introduced a behavior change where this behavior was true and now defaults to false. This caused our test to break.
In order to maintain the same behavior we have to manually enable this config.
more info FasterXML/jackson-core#1038
RanVaknin
added
the
no-api-surface-area-change
L-Applin
approved these changes
Oct 31, 2025
RanVaknin
force-pushed
the
rvaknin/upgrade-jackson-version-2.19.4
branch
from
e849402 to
f11ca49
Compare
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump Jackson to 2.19.4
Testing:
The results seem flat aside from getJson1kb (p99) which might be an anomaly or related to code changes from that pr (the benchmark tests that test 2.19.4 have to use a new feature that has to do with escaping surrogate pairs but its unlikely to be related)