Fix VersionedRecordExtension to sanitize attribute names in expression value keys

[zoewangg]

Motivation and Context

Fixes #3279

When using @DynamoDbVersionAttribute with attribute names containing special characters (hyphens, dots, colons, etc.), DynamoDB operations fail with:

DynamoDbException: ExpressionAttributeValues contains invalid key: Syntax error; key: ":old_my-version-attribute_value"

The issue occurs because VersionedRecordExtension generates expression value placeholder keys directly from the attribute name without sanitizing special characters, which are not allowed in DynamoDB
expression value placeholders.

Modifications

Updated VERSIONED_RECORD_EXPRESSION_VALUE_KEY_MAPPER to use cleanAttributeName() when generating expression value placeholder keys. This ensures special characters in version attribute names are replaced with underscores, making the placeholders valid

Changed:

// Before
private static final Function<String, String> VERSIONED_RECORD_EXPRESSION_VALUE_KEY_MAPPER =
    key -> ":old_" + key + "_value";

// After
private static final Function<String, String> VERSIONED_RECORD_EXPRESSION_VALUE_KEY_MAPPER =
    key -> ":old_" + cleanAttributeName(key) + "_value";

Note that this will not introduce breaking behavior as it only affects the Bug Case

• Attribute names without special characters generate the same placeholder as before:
  • "version" → :old_version_value (unchanged)
• Attribute names with special characters now work instead of failing:
  • "my-version" → :old_my_version_value (was throwing exception before)

Testing

Updated existing test case to use an attribute key name with invalid character

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)

Checklist

• [x] I have read the CONTRIBUTING document
• [x] Local run of mvn install succeeds
• [x] My code follows the code style of this project
• [ ] My change requires a change to the Javadoc documentation
• [ ] I have updated the Javadoc documentation accordingly
• [x] I have added tests to cover my changes
• [x] All new and existing tests passed
• [ ] I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in
.changes/next-release with your changes.
• [ ] My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• [x] I confirm that this pull request can be released under the Apache 2 license

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.