Add tests for named require with local name (#339)

Author: trivikr

scripts/generateNewClientTests/getServiceRequireWithNameInput.ts

@@ -0,0 +1,16 @@
+import { CLIENTS_TO_TEST, LOCAL_NAME_SUFFIX } from "./config";
+import { getV2ClientsNewExpressionCode } from "./getV2ClientsNewExpressionCode";
+
+export const getServiceRequireWithNameInput = (codegenComment: string) => {
+  let serviceRequireInputContent = `${codegenComment}\n`;
+
+  serviceRequireInputContent += `const { \n${CLIENTS_TO_TEST.map(
+    (clientName) => `  ${clientName}: ${clientName}${LOCAL_NAME_SUFFIX}`
+  ).join(`,\n`)}\n} = require("aws-sdk");\n`;
+  serviceRequireInputContent += `\n`;
+  serviceRequireInputContent += getV2ClientsNewExpressionCode(
+    CLIENTS_TO_TEST.map((clientName) => `${clientName}${LOCAL_NAME_SUFFIX}`)
+  );
+
+  return serviceRequireInputContent;
+};

scripts/generateNewClientTests/getServiceRequireWithNameOutput.ts

@@ -0,0 +1,29 @@
+import { CLIENT_NAMES_MAP, CLIENT_PACKAGE_NAMES_MAP } from "../../src/transforms/v2-to-v3/config";
+import { CLIENTS_TO_TEST, LOCAL_NAME_SUFFIX } from "./config";
+import { getClientNamesSortedByPackageName } from "./getClientNamesSortedByPackageName";
+import { getV3ClientsNewExpressionCode } from "./getV3ClientsNewExpressionCode";
+
+export const getServiceRequireWithNameOutput = (codegenComment: string) => {
+  let globalRequireOutputContent = `${codegenComment}\n`;
+
+  const sortedClientNames = getClientNamesSortedByPackageName(CLIENTS_TO_TEST);
+  globalRequireOutputContent += `const `;
+  for (const v2ClientName of sortedClientNames) {
+    const v3ClientName = CLIENT_NAMES_MAP[v2ClientName];
+    const v3ClientPackageName = `@aws-sdk/${CLIENT_PACKAGE_NAMES_MAP[v2ClientName]}`;
+    const v3ClientLocalName = `${v2ClientName}${LOCAL_NAME_SUFFIX}`;
+    const v3RequireKeyValuePair =
+      v3ClientName === v3ClientLocalName ? v3ClientName : `${v3ClientName}: ${v3ClientLocalName}`;
+    globalRequireOutputContent +=
+      `{\n` +
+      `        ${v3RequireKeyValuePair}\n` +
+      `      } = require("${v3ClientPackageName}"),\n` +
+      `      `;
+  }
+  globalRequireOutputContent = globalRequireOutputContent.replace(/,\n {6}$/, ";\n\n");
+  globalRequireOutputContent += getV3ClientsNewExpressionCode(
+    CLIENTS_TO_TEST.map((clientName) => `${clientName}${LOCAL_NAME_SUFFIX}`)
+  );
+
+  return globalRequireOutputContent;
+};

scripts/generateNewClientTests/index.ts

@@ -21,6 +21,8 @@ import { getServiceRequireDeepInput } from "./getServiceRequireDeepInput";
 import { getServiceRequireDeepOutput } from "./getServiceRequireDeepOutput";
 import { getServiceRequireInput } from "./getServiceRequireInput";
 import { getServiceRequireOutput } from "./getServiceRequireOutput";
+import { getServiceRequireWithNameInput } from "./getServiceRequireWithNameInput";
+import { getServiceRequireWithNameOutput } from "./getServiceRequireWithNameOutput";
 
 // The "use strict" directive is added to so that comments can be attached to it.
 // Recast removes the comments while removing import/require.
@@ -52,6 +54,8 @@ const newClientTestsPath = join(__dirname, "..", "..", newClientsTestsFolder);
     ["service-require.output.js", getServiceRequireOutput],
     ["service-require-deep.input.js", getServiceRequireDeepInput],
     ["service-require-deep.output.js", getServiceRequireDeepOutput],
+    ["service-require-with-name.input.js", getServiceRequireWithNameInput],
+    ["service-require-with-name.output.js", getServiceRequireWithNameOutput],
   ] as [string, (comment: string) => string][]) {
     const filePath = join(newClientTestsPath, fileName);
     await writeFile(filePath, getFileContent(codegenComment));

src/transforms/v2-to-v3/__fixtures__/new-client/service-require-with-name.input.js

@@ -0,0 +1,12 @@
+// This file is generated by scripts/generateNewClientTests/index.ts
+// Do not edit this file directly. Instead, edit the script and run it to regenerate this file.
+"use strict";
+const { 
+  ACM: ACMClient,
+  AccessAnalyzer: AccessAnalyzerClient,
+  Discovery: DiscoveryClient
+} = require("aws-sdk");
+
+new ACMClient();
+new AccessAnalyzerClient();
+new DiscoveryClient();

src/transforms/v2-to-v3/__fixtures__/new-client/service-require-with-name.output.js

@@ -0,0 +1,16 @@
+// This file is generated by scripts/generateNewClientTests/index.ts
+// Do not edit this file directly. Instead, edit the script and run it to regenerate this file.
+"use strict";
+const {
+        AccessAnalyzer: AccessAnalyzerClient
+      } = require("@aws-sdk/client-accessanalyzer"),
+      {
+        ACM: ACMClient
+      } = require("@aws-sdk/client-acm"),
+      {
+        ApplicationDiscoveryService: DiscoveryClient
+      } = require("@aws-sdk/client-application-discovery-service");
+
+new ACMClient();
+new AccessAnalyzerClient();
+new DiscoveryClient();