Skip to content

Commit d194142

Browse files
authored
Support transformation of S3 getSignedUrl (#517)
1 parent d21db67 commit d194142

30 files changed

+466
-42
lines changed

.changeset/sour-yaks-smell.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"aws-sdk-js-codemod": minor
3+
---
4+
5+
Support transformation of S3 getSignedUrl
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import AWS from "aws-sdk";
2+
3+
const s3 = new AWS.S3();
4+
const params = { Bucket: "bucket", Key: "key" };
5+
6+
s3.getSignedUrl("getObject", params, function (err, url) {
7+
console.log('The URL is', url);
8+
});
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
import AWS from "aws-sdk";
2+
3+
const s3 = new AWS.S3();
4+
const params = { Bucket: "bucket", Key: "key" };
5+
6+
// S3 getSignedUrl with callbacks are not supported in AWS SDK for JavaScript (v3).
7+
// Please convert to 'client.getSignedUrl(apiName, options)', and re-run aws-sdk-js-codemod.
8+
s3.getSignedUrl("getObject", params, function (err, url) {
9+
console.log('The URL is', url);
10+
});
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import AWS from "aws-sdk";
2+
3+
const s3 = new AWS.S3();
4+
const params = { Bucket: "bucket", Key: "key" };
5+
6+
url = s3.getSignedUrl("getObject", params);
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
import { getSignedUrl } from "@aws-sdk/s3-request-presigner";
2+
import { GetObjectCommand, S3 } from "@aws-sdk/client-s3";
3+
4+
const s3 = new S3();
5+
const params = { Bucket: "bucket", Key: "key" };
6+
7+
url = await getSignedUrl(s3, new GetObjectCommand(params), {
8+
expiresIn: "/* add value from 'Expires' from v2 call if present, else remove */"
9+
});
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import AWS = require("aws-sdk");
2+
3+
const s3 = new AWS.S3();
4+
5+
url = s3.getSignedUrl("getObject", { Bucket: "bucket", Key: "key" });
6+
url = s3.getSignedUrl("getObject", { Bucket: "bucket", Key: "key", Expires: 60 });
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
import AWS_s3_request_presigner = require("@aws-sdk/s3-request-presigner");
2+
3+
const {
4+
getSignedUrl
5+
} = AWS_s3_request_presigner;
6+
7+
import AWS_S3 = require("@aws-sdk/client-s3");
8+
9+
const {
10+
GetObjectCommand,
11+
S3
12+
} = AWS_S3;
13+
14+
const s3 = new S3();
15+
16+
url = await getSignedUrl(s3, new GetObjectCommand({ Bucket: "bucket", Key: "key" }));
17+
url = await getSignedUrl(s3, new GetObjectCommand({
18+
Bucket: "bucket",
19+
Key: "key"
20+
}), {
21+
expiresIn: 60
22+
});
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import AWS from "aws-sdk";
2+
3+
const s3 = new AWS.S3();
4+
5+
url = s3.getSignedUrl("getObject", { Bucket: "bucket", Key: "key" });
6+
url = s3.getSignedUrl("getObject", { Bucket: "bucket", Key: "key", Expires: 60 });
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import { getSignedUrl } from "@aws-sdk/s3-request-presigner";
2+
import { GetObjectCommand, S3 } from "@aws-sdk/client-s3";
3+
4+
const s3 = new S3();
5+
6+
url = await getSignedUrl(s3, new GetObjectCommand({ Bucket: "bucket", Key: "key" }));
7+
url = await getSignedUrl(s3, new GetObjectCommand({
8+
Bucket: "bucket",
9+
Key: "key"
10+
}), {
11+
expiresIn: 60
12+
});
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
import AWS from "aws-sdk";
2+
3+
const s3 = new AWS.S3();
4+
const params = { Bucket: "bucket", Key: "key" };
5+
6+
url = await s3.getSignedUrlPromise("getObject", params);
7+
8+
url = await s3.getSignedUrlPromise("getObject", { Bucket: "bucket", Key: "key" });
9+
url = await s3.getSignedUrlPromise("getObject", { Bucket: "bucket", Key: "key", Expires: 60 });

0 commit comments

Comments
 (0)