Skip to content

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 5, 2024

Issue

Changeset does not update lockfile version changesets/changesets#1139

Description

Updates lockfile before posting changeset PR

Testing

Verified that package-lock.json is updated.

$ npm run prerelease
...

$ git status
On branch changeset-lockfile-version
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        deleted:    .changeset/mean-sheep-refuse.md
        modified:   CHANGELOG.md
        modified:   package-lock.json
        modified:   package.json

$ git diff package-lock.json | head
diff --git a/package-lock.json b/package-lock.json
index abe4451..56c5632 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "aws-sdk-js-codemod",
-  "version": "2.4.2",
+  "version": "2.4.3",
   "lockfileVersion": 3,

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 5ee986a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trivikr trivikr marked this pull request as ready for review November 5, 2024 04:48
@trivikr trivikr requested a review from a team as a code owner November 5, 2024 04:48
@trivikr trivikr merged commit a92e2d3 into main Nov 5, 2024
7 checks passed
@trivikr trivikr deleted the changeset-lockfile-version branch November 5, 2024 04:48
@trivikr
Copy link
Member Author

trivikr commented Nov 5, 2024

The changeset action did not update package-lock.json file when this code was merged to main branch

Switched to a new branch 'changeset-release/main'
/usr/bin/git reset --hard a92e2d356f5a44d7517aa7a15310d0a96da7ee98
HEAD is now at a92e2d3 Update lockfile before posting changeset PR (#965)
/usr/local/bin/node /home/runner/work/aws-sdk-js-codemod/aws-sdk-js-codemod/node_modules/@changesets/cli/bin.js version
🦋  All files have been updated. Review them and commit at your leisure
/usr/bin/git status --porcelain
 D .changeset/mean-sheep-refuse.md
 M CHANGELOG.md
 M package.json
/usr/bin/git add .

https://github.com/aws/aws-sdk-js-codemod/actions/runs/11677764659/job/32516190146

Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant