Skip to content

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Mar 25, 2025

Issue

The command corepack enable is not required to be run for after globally installing corepack
https://www.github.com/nodejs/corepack/issues/104#issuecomment-2746172451

Description

Removes redundant command corepack enable

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner March 25, 2025 04:31
Copy link

changeset-bot bot commented Mar 25, 2025

⚠️ No Changeset found

Latest commit: 6c2b377

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trivikr
Copy link
Member Author

trivikr commented Mar 25, 2025

Corepack installation needs to be before action/setup-node, else it doesn't use yarn version from devEngines field.

Noticed in https://github.com/aws/aws-sdk-js-codemod/actions/runs/14052278544/job/39344738905?pr=979

@trivikr trivikr merged commit b0105f8 into main Mar 25, 2025
7 checks passed
@trivikr trivikr deleted the remove-corepack-enable branch March 25, 2025 05:34
Copy link
Contributor

github-actions bot commented Apr 9, 2025

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant