Skip to content

fix(middleware-user-agent): ignore errors from inspecting credentials #6551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix(middleware-user-agent): ignore errors from inspecting credentials #6551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions packages/middleware-user-agent/src/check-features.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,19 @@ export async function checkFeatures(
}

if (typeof config.credentials === "function") {
const credentials: AttributedAwsCredentialIdentity = await config.credentials?.();
if (credentials.accountId) {
setFeature(context, "RESOLVED_ACCOUNT_ID", "T");
}
for (const [key, value] of Object.entries(credentials.$source ?? {})) {
setFeature(context, key as keyof AwsSdkCredentialsFeatures, value);
try {
const credentials: AttributedAwsCredentialIdentity = await config.credentials?.();
if (credentials.accountId) {
setFeature(context, "RESOLVED_ACCOUNT_ID", "T");
}
for (const [key, value] of Object.entries(credentials.$source ?? {})) {
setFeature(context, key as keyof AwsSdkCredentialsFeatures, value);
}
} catch (e: unknown) {
// Sometimes config.credentials is a function but only throws
// as a way of informing users that something is missing.
// That error and any other credential retrieval errors are
// not relevant for feature-checking and should be ignored.
}
}
}
Loading