Skip to content

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 18, 2024

Issue

Internal JS-5505

Description

Skips preview legacy:e2e tests if client is not found

Testing

Tested with preview build internal artifact

Before

Error is thrown:

$ yarn test:e2e:legacy:preview
yarn run v1.22.22
$ ./tests/e2e-legacy/preview.mjs
Updated packages: [object Set]
Couldn't find clients in commit messages:
 ''
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

After

Error is not thrown

$  yarn test:e2e:legacy:preview    
yarn run v1.22.22
$ ./tests/e2e-legacy/preview.mjs
Updated packages: 
Couldn't find clients in commit messages:
 ''
Done in 0.11s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review October 18, 2024 20:59
@trivikr trivikr requested a review from a team as a code owner October 18, 2024 20:59
@trivikr trivikr merged commit 3f84c75 into aws:main Oct 18, 2024
2 checks passed
@trivikr trivikr deleted the skip-preview-e2e-test-if-no-clients-found branch October 18, 2024 21:10
Copy link

github-actions bot commented Nov 3, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants