Skip to content

fix: update error messge to NumberValue #6579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 22, 2024
Merged

fix: update error messge to NumberValue #6579

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b77eabc
update error messge to NumberValue
zshzbh Oct 20, 2024
9473f71
fix: update error messge to NumberValue
zshzbh Oct 20, 2024
783d875
Merge branch 'main' of https://github.com/zshzbh/aws-sdk-js-v3
zshzbh Oct 20, 2024
698e92a
fix: wording
kuhe Oct 21, 2024
0038983
fix: wording
kuhe Oct 21, 2024
09f2bb7
fix: wording
kuhe Oct 21, 2024
a3c4626
fix: wording
kuhe Oct 21, 2024
4a36ff7
fix: update error message to NumberValue
zshzbh Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/util-dynamodb/src/convertToAttr.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ describe("convertToAttr", () => {

expect(() => {
convertToAttr(num, { convertClassInstanceToMap });
}).toThrowError(`${errorPrefix} Use BigInt.`);
}).toThrowError(`${errorPrefix} Use NumberValue, which is introduced from @aws-sdk/lib-dynamodb.`);

const BigIntConstructor = BigInt;
(BigInt as any) = undefined;
Expand All @@ -81,7 +81,7 @@ describe("convertToAttr", () => {

expect(() => {
convertToAttr(num, { convertClassInstanceToMap });
}).toThrowError(`${errorPrefix} Use BigInt.`);
}).toThrowError(`${errorPrefix} Use NumberValue, which is introduced from @aws-sdk/lib-dynamodb.`);

const BigIntConstructor = BigInt;
(BigInt as any) = undefined;
Expand Down
4 changes: 2 additions & 2 deletions packages/util-dynamodb/src/convertToAttr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ const convertToBinaryAttr = (data: NativeAttributeBinary): { B: NativeAttributeB
const convertToStringAttr = (data: string | String): { S: string } => ({ S: data.toString() });
const convertToBigIntAttr = (data: bigint): { N: string } => ({ N: data.toString() });

const validateBigIntAndThrow = (errorPrefix: string) => {
throw new Error(`${errorPrefix} ${typeof BigInt === "function" ? "Use BigInt." : "Pass string value instead."} `);
const validateBigIntAndThrow = (errorPrefix: string) => {
throw new Error(`${errorPrefix} ${typeof BigInt === "function" ? "Use NumberValue, which is introduced from @aws-sdk/lib-dynamodb." : "Pass string value instead."} `);
};

const convertToNumberAttr = (num: number | Number): { N: string } => {
Expand Down
Loading