Skip to content

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Nov 4, 2024

Issue

Mocking of STS caused a bug in https://github.com/aws/aws-sdk-js-v3/releases/tag/v3.667.0 to not be caught.

Description

Removes the mocking of the STS and SSO clients in the credential provider chain's integration test. The mocking is moved to the HTTP Handler level.

Testing

CI / running these integration tests.

Verifying that this would've caught the issue in v3.667.0:

git checkout v3.667.0
make tpk # builds packages only
b cred prov node - integ # runs integration tests, hangs
git checkout v3.668.0 # patched version
make tpk # builds packages only
b cred prov node - integ # runs integration tests, succeeds

@kuhe kuhe requested a review from a team as a code owner November 4, 2024 16:59

xit("should prefer static credentials over role assumption metadata only if the profile is not the first one visited", async () => {
// TODO
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case isn't necessary, because other tests cover it.

I wrote this initially when I was going over the default credential provider chain and it looked like a distinct use-case, but isn't.

@kuhe kuhe merged commit 62ae71a into aws:main Nov 4, 2024
4 checks passed
@kuhe kuhe deleted the test/chain branch November 4, 2024 18:16
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants