Skip to content

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Nov 8, 2024

No description provided.

@kuhe kuhe requested a review from a team as a code owner November 8, 2024 19:02
it.each([
[ChecksumAlgorithm.MD5, mockConfig.md5],
[ChecksumAlgorithm.CRC32, getCrc32ChecksumAlgorithmFunction()],
// [ChecksumAlgorithm.CRC32, getCrc32ChecksumAlgorithmFunction()],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯
--
266 |  
267 | FAIL  packages/middleware-flexible-checksums/src/selectChecksumAlgorithmFunction.spec.ts > selectChecksumAlgorithmFunction > testing CRC32
268 | AssertionError: expected [Function NodeCrc32] to deeply equal [Function NodeCrc32]
269 |  
270 | Compared values have no visual difference.
271 |  
272 | ❯ packages/middleware-flexible-checksums/src/selectChecksumAlgorithmFunction.spec.ts:22:83
273 | 20\|     [ChecksumAlgorithm.SHA256, mockConfig.sha256],
274 | 21\|   ])("testing %s", (checksumAlgorithm, output) => {
275 | 22\|     expect(selectChecksumAlgorithmFunction(checksumAlgorithm, mockConf…
276 | \|                                                                                   ^
277 | 23\|   });
278 | 24\| });
279 |  
280 | ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

@kuhe kuhe changed the title main test(middleware-flexible-checksums): disable test case Nov 8, 2024
@kuhe kuhe merged commit a87b853 into aws:main Nov 8, 2024
2 checks passed
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants