Skip to content

fix(util-user-agent-node): appId config file name correction #6729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 13, 2024
Merged

fix(util-user-agent-node): appId config file name correction #6729

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6128b63
chore(util-user-agent-node): appId config file name correction
siddsriv Dec 13, 2024
6df2e22
chore(util-user-agent-node): add deprecated name
siddsriv Dec 13, 2024
5526ace
chore(util-user-agent-node): deprecated annotation
siddsriv Dec 13, 2024
ea7b7c9
chore(util-user-agent-node): remove export
siddsriv Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/util-user-agent-node/src/nodeAppIdConfigOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { LoadedConfigSelectors } from "@smithy/node-config-provider";
import { DEFAULT_UA_APP_ID } from "@aws-sdk/middleware-user-agent";

import { LoadedConfigSelectors } from "@smithy/node-config-provider";

/**
* @internal
Expand All @@ -10,13 +9,18 @@ export const UA_APP_ID_ENV_NAME = "AWS_SDK_UA_APP_ID";
/**
* @internal
*/
export const UA_APP_ID_INI_NAME = "sdk-ua-app-id";
export const UA_APP_ID_INI_NAME = "sdk_ua_app_id";

/**
* @deprecated
*/
export const UA_APP_ID_INI_NAME_DEPRECATED = "sdk-ua-app-id";

/**
* @internal
*/
export const NODE_APP_ID_CONFIG_OPTIONS: LoadedConfigSelectors<string | undefined> = {
environmentVariableSelector: (env) => env[UA_APP_ID_ENV_NAME],
configFileSelector: (profile) => profile[UA_APP_ID_INI_NAME],
configFileSelector: (profile) => profile[UA_APP_ID_INI_NAME] ?? profile[UA_APP_ID_INI_NAME_DEPRECATED],
default: DEFAULT_UA_APP_ID,
};
Loading