Skip to content

fix(nested-clients): create nested clients for internal use #6791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 16, 2025
Merged

fix(nested-clients): create nested clients for internal use #6791

merged 12 commits into from
Jan 16, 2025

Conversation

@kuhe
Copy link
Contributor

@kuhe kuhe commented Jan 9, 2025 •
edited
Loading

Issue

#6258
#5818 etc.

  • multiple tickets related to either circular dependencies, incorrect peers, or bundle size

Description

  • create nested STS and SSO-OIDC clients in a separate package
  • compress rulesets
  • generate with pared down operation list
  • investigate what other optional components can be removed

Testing

  • CI passing with existing credential provider tests

@kuhe kuhe force-pushed the feat/nested-clients branch 4 times, most recently from e4ff49a to 9eaf934 Compare January 13, 2025 15:58
trivikr
trivikr reviewed Jan 13, 2025
View reviewed changes
@kuhe
Copy link
Contributor Author

kuhe commented Jan 13, 2025 •
edited
Loading

  • create submodules using package.json imports similar to what was done in @aws-sdk/core.

@kuhe kuhe force-pushed the feat/nested-clients branch from 9eaf934 to a881bbd Compare January 15, 2025 16:30
@kuhe kuhe marked this pull request as ready for review January 15, 2025 18:55
@kuhe kuhe requested a review from a team as a code owner January 15, 2025 18:55
@kuhe kuhe merged commit 5c53685 into aws:main Jan 16, 2025
4 checks passed
@kuhe kuhe deleted the feat/nested-clients branch January 16, 2025 15:22
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kuhe @trivikr