Skip to content

chore(middleware-sdk-s3): unset SessionMode default value #6860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kuhe merged 1 commit into from
Jan 31, 2025
Merged

chore(middleware-sdk-s3): unset SessionMode default value #6860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/middleware-sdk-s3/src/s3-express/middleware-s3-express.integ.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,23 @@ describe("middleware-s3-express", () => {
};

describe(S3.name, () => {
it("should not send the x-amz-create-session-mode header", async () => {
const client = new S3({ region: "us-west-2", s3ExpressIdentityProvider });

requireRequestsFrom(client).toMatch({
headers: {
"x-amz-create-session-mode": /undefined/,
},
});

await client.getObject({
Bucket: "aws-sdk-js-v3-test--usw2-az1--x-s3",
Key: "1",
});

expect.hasAssertions();
});

it("should default to CRC32 checksum when the request requires a checksum and none is specified", async () => {
const client = new S3({ region: "us-west-2", s3ExpressIdentityProvider });

Expand Down
1 change: 0 additions & 1 deletion packages/middleware-sdk-s3/src/s3Configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ export const resolveS3Config = <T>(
s3ClientProvider().send(
new CreateSessionCommandCtor({
Bucket: key,
SessionMode: "ReadWrite",
})
)
),
Expand Down
Loading